[wp-trac] [WordPress Trac] #26646: On Appearance themes page ".themes" div is not covering floated elements.

WordPress Trac noreply at wordpress.org
Thu Apr 2 07:42:58 UTC 2015


#26646: On Appearance themes page ".themes" div is not covering floated elements.
--------------------------+---------------------------------
 Reporter:  5um17         |       Owner:  obenland
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Future Release
Component:  Themes        |     Version:  3.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by 5um17):

 Replying to [comment:21 helen]:
 > Punting from 4.2, because:
 >
 > 1. This is not causing functional issues as far as I have been able to
 ascertain.
 > 2. It looks weird with all that bottom margin applying now, so the
 visual change needs to be considered.
 > 3. If this is about a holistic change, then let's take it together with
 general clearfixing: #26396.

 I agree with your 2nd and 3rd points but I just want to know, do we only
 fix functional issues there is nothing to do with CSS standards ? As we
 all know we need to clear the floated elements for best practice. Apart
 from this as I commented earlier there is an unused element {{{<br
 class="clear" />}}} which have no effect in whole page so I guess we need
 to fix that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26646#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list