[wp-trac] [WordPress Trac] #31233: Dismissable admin notices

WordPress Trac noreply at wordpress.org
Wed Apr 1 21:59:27 UTC 2015


#31233: Dismissable admin notices
-----------------------------------+--------------------------------
 Reporter:  ryan                   |       Owner:  helen
     Type:  task (blessed)         |      Status:  reviewing
 Priority:  normal                 |   Milestone:  4.2
Component:  Administration         |     Version:  4.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 4.2-strings  |     Focuses:  ui, accessibility
-----------------------------------+--------------------------------
Changes (by helen):

 * keywords:  has-patch, 4.2-strings => has-patch 4.2-strings


Comment:

 @valendesigns: All looks really good, thanks. In doing final review, etc.,
 I changed `.notice-close` to `.notice-dismiss` for consistency and defined
 the icon for that element rather than keeping the extra span. I also
 expanded the usage to other places in the admin, of which there were a
 lot. Most core notices will now have them, with the exception of a couple
 of errors. There may be some that don't really need to be dismissed, but
 it's not super intrusive so I'm going to roll with it as-is and we can
 selectively back stuff out later if something seems really egregious.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31233#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list