[wp-trac] [WordPress Trac] #31849: Fix wrong use of __x()

WordPress Trac noreply at wordpress.org
Wed Apr 1 21:30:20 UTC 2015


#31849: Fix wrong use of __x()
--------------------------+-----------------------------
 Reporter:  ramiy         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  I18N          |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  multisite
--------------------------+-----------------------------
Changes (by ocean90):

 * keywords:   => has-patch
 * focuses:   => multisite
 * component:  General => I18N
 * milestone:  Awaiting Review => Future Release


Old description:

> Should be __()

New description:

 Should be `__()`

--

Comment:

 `_x()` is actually correct since it has a context: `'%1$s: site name.
 %2$s: site tagline.'`, But yeah, it should be moved to a translator
 comment and `__()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31849#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list