[wp-trac] [WordPress Trac] #29719: Connection error to WordPres.org when HTTP calls disabled

[WordPress Trac]

#29719: Connection error to WordPres.org when HTTP calls disabled
-----------------------------+------------------------------
 Reporter:  grapplerulrich   |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  4.0
 Severity:  minor            |  Resolution:
 Keywords:                   |     Focuses:  administration
-----------------------------+------------------------------
Changes (by francescolaffi):

 * component:  HTTP API => Upgrade/Install
 * severity:  normal => minor


Comment:

 I could reproduce the error that only is visible if errors output is
 enabled and does not break the generation of the page. Of course I guess
 nobody expects updates to work if http requests are disabled but it could
 be handled better.

 At the end of update.php you linked
 https://github.com/WordPress/WordPress/blob/master/wp-
 includes/update.php#L651 several update related functions are hooked
 around, there is a condition to esclude it in some cases (es: subsites in
 multisite), it could be a good idea be a conditional to avoid it if its
 not possible to do the checks (something like `if
 (block_request('api.wordpress.org')) ...`)

 Also the updates admin page could say that its not possible to check for
 updates instead that saying that there are no updates.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29719#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform