[wp-trac] [WordPress Trac] #29257: media_sideload_image() calls rename() on temp file, which can break streams

[WordPress Trac]

#29257: media_sideload_image() calls rename() on temp file, which can break streams
--------------------------+------------------------------
 Reporter:  joehoyle      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  3.9.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by joehoyle):

 Patch still applies cleanly.

 Discussed briefly with johnbillion, potential issue: server doesn't have
 room to copy the file so fails. However, in the case of
 `move_uploaded_file` being called - then double the image uploaded file
 size is required as `move_uploaded_file` does a copy operation, not a
 rename; any checks that make use of this function will apply to both and I
 don't think should be applied to this small-fix path.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29257#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform