[wp-trac] [WordPress Trac] #27747: Inconsistent type default between `submit_button()` and `get_submit_button()`

[WordPress Trac]

#27747: Inconsistent type default between `submit_button()` and
`get_submit_button()`
-----------------------------------+---------------------------------------
 Reporter:  Denis-de-Bernardy      |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Administration         |     Version:  3.5
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  administration, template
-----------------------------------+---------------------------------------
Changes (by OriginalEXE):

 * keywords:   => has-patch 2nd-opinion


Comment:

 Patch attached,

 I checked the usage of get_submit_button function throughout the WP code
 and $type parameter is specified in each, so this change would not affect
 the WP admin.

 The only side effect of this change is that button class would change in
 plugins/themes that count on 'primary large' to be a default, but I would
 say consistency between functions is more important.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27747#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform