[wp-trac] [WordPress Trac] #29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts

[WordPress Trac]

#29557: PHP ≤ 5.4.8 Crashes on '[' Character in Posts
-----------------------------------+--------------------
 Reporter:  MrBobDobolina          |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest omg bbq        |   Milestone:  4.0.1
Component:  Formatting             |     Version:  4.0
 Severity:  blocker                |  Resolution:
 Keywords:  wptexturize has-patch  |     Focuses:
-----------------------------------+--------------------
Changes (by miqrogroove):

 * keywords:  wptexturize => wptexturize has-patch


Comment:

 I experimented with several more solutions and this one seems to be the
 most optimal so far.

 In miqro-29557.8.patch:
 * Revert parts of [28773] and [28727] and [29748].
 * Do not crash PHP. Make the shortcode quantifier possessive to avoid
 backtracks.
 * Reduce backtracking in long HTML comments by 100x.
 * Do not ignore unclosed HTML comments.
 * Do not break unregistered shortcodes, e.g. [hello attr="value"].
 * Do not break HTML in shortcode attributes, e.g. [hello attr="<"].
 * Do not match for shortcodes when there is extra whitespace, e.g. [ hello
 ].
 * Add unit tests to show #12690 was not fully resolved.
 * Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29557#comment:71>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform