[wp-trac] [WordPress Trac] #29629: Shortcode playlist random order parameter can't work

WordPress Trac noreply at wordpress.org
Tue Sep 23 03:51:26 UTC 2014


#29629: Shortcode playlist random order parameter can't work
--------------------------+-----------------------------
 Reporter:  ialocin       |       Owner:  wonderboymusic
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.1
Component:  Media         |     Version:  4.0
 Severity:  major         |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"29760"]:
 {{{
 #!CommitTicketReference repository="" revision="29760"
 Ordering by `RAND()`:

 The shortcode callbacks for `gallery` and `playlist` check for `'RAND' ==
 $atts['order']`, which isn't a valid value for `order`. Remove those
 checks and update the docs.

 In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant
 and should be unset.

 Adds unit tests.

 Fixes #29629.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29629#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list