[wp-trac] [WordPress Trac] #29718: Improved coverage for WP_Tax_Query unit tests
WordPress Trac
noreply at wordpress.org
Mon Sep 22 13:24:31 UTC 2014
#29718: Improved coverage for WP_Tax_Query unit tests
--------------------------+------------------------------
Reporter: boonebgorges | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Taxonomy | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------------------
Comment (by boonebgorges):
29718.02.patch is a refresh that adds tests for this lovely bit of
backward-compatibility: https://core.trac.wordpress.org/browser/trunk/src
/wp-includes/query.php?annotate=blame#L2701 (as introduced to address
#12659). Note that a couple of these tests are marked `@ticket 29718`
because they're currently failing. I believe that these failures are due
to bugs in the existing code (not checking an array index before using it,
and not checking all meta_query clauses before setting the category- and
tag-related vars). I'll write up a separate ticket soon for these bugs
(and in fact they'll be fixed as part of a larger rewrite I'm working on),
but for now I wanted to ensure that all the relevant tests were included
in a single patch so that they'd apply cleanly.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29718#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list