[wp-trac] [WordPress Trac] #29715: Not-unique accesskey values may break quick edit and bulk edit form submission

[WordPress Trac]

#29715: Not-unique accesskey values may break quick edit and bulk edit form
submission
--------------------------+-----------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Please try this in Chrome:
 - go in the posts listing screen
 - don't click anything, just activate the "s" accesskey (e.g. Alt + s on
 Windows)
 or:
 - go in the posts listing screen
 - click "Quick Edit" for a post
 - activate the "s" accesskey (e.g. Alt + s on Windows)

 You've just submitted the whole inline-edit/bulk-edit form.
 [https://cloudup.com/ck9MggKKb8e see screenshot], notice all the
 parameters in your browser's address bar. When the page reloads, it will
 try to display posts based on those (mostly empty) parameters and the
 result will be 0 posts.

 Try the same in Firefox (Alt + Shift + s on Windows): nothing happens.
 Click "Quick Edit" and try Alt + Shift + c to cancel: Firefox won't even
 move the focus from the focused input.

 Browsers behaviour is really messy with not-unique accesskey values. As
 far as I see there are 3 places in WordPress where this happens:
 1. post listings
 2. categories and tags listings
 3. Quicktags in the edit post and new post screens

 About 1 and 2, please notice that when you "Quick edit", the "inline edit"
 part of the form (hidden with CSS) gets cloned and populated. Of course,
 accesskey attributes get cloned too.

 The proposed patch simply removes accesskeys for 1 and 2. For a strong
 opinion about accesskeys, see
 [https://core.trac.wordpress.org/ticket/29358#comment:2 @joedolson
 comment].

 About Quicktags, see #29358, #28173 and #21460.

 There's one more accesskey: the "p" on the Publish button. I'd suggest to
 remove that too unless there are strong opinions to keep it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29715>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform