[wp-trac] [WordPress Trac] #12031: Install do not check the magic_quote_sybase status

[WordPress Trac]

#12031: Install do not check the magic_quote_sybase status
--------------------------------------+---------------------
 Reporter:  wpmuguru                  |       Owner:  egill
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  4.0
Component:  Upgrade/Install           |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+---------------------
Changes (by nacin):

 * keywords:  good-first-bug has-patch 4.1-early => good-first-bug has-patch
 * status:  assigned => closed
 * resolution:   => fixed
 * milestone:  Future Release => 4.0


Comment:

 Replying to [comment:16 egill]:
 > Replying to [comment:15 maxzeroedge]:
 > > Wouldn't suppressing the error in ini_set bring up troubles if it
 couldn't set? Instead we could check if it is active and then disable it?
 >
 > You're right (I should have paid a bit more attention creating the
 previous patch), thanks for the suggestion. Uploaded a new patch:
 > https://core.trac.wordpress.org/attachment/ticket/12031/12031.2.patch

 I think we error suppress ini_set() for when the function might end up in
 disabled_functions by annoying hosts. I would just copy exactly what we do
 in wp-settings.php, so the first patch.

 '''However''', and I'm sorry for the 'bad' news for those who worked on
 this ticket in the last few months, but this was fixed incidentally in
 4.0, as setup-config.php now loads wp-settings.php. See #28740, [28978].

 Good news is, we just retroactively increased our fixed bugs count for 4.0
 by one.

 Thanks all. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12031#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform