[wp-trac] [WordPress Trac] #15000: add_meta_box() should accept array of post types
WordPress Trac
noreply at wordpress.org
Fri Sep 12 05:29:03 UTC 2014
#15000: add_meta_box() should accept array of post types
-------------------------------------------------+-------------------------
Reporter: coffee2code | Owner:
Type: enhancement | iamfriendly
Priority: normal | Status: assigned
Component: Administration | Milestone: Awaiting
Severity: minor | Review
Keywords: good-first-bug needs-patch needs- | Version: 3.0.1
unit-tests | Resolution:
| Focuses:
-------------------------------------------------+-------------------------
Changes (by nacin):
* keywords: good-first-bug has-patch => good-first-bug needs-patch needs-
unit-tests
Comment:
No need to change the spaces in the @param lines — those are accurate as
is.
Rather than the ! isset return at the end, I'd just return after the
foreach.
We'd also have to make a similar change for remove_meta_box() too.
Ideally, we'll add some basic unit tests as well, to
tests/phpunit/tests/admin/includesTemplate.php.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/15000#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list