[wp-trac] [WordPress Trac] #28113: class-wp-embed. height always fake in $attr

WordPress Trac noreply at wordpress.org
Thu Sep 11 19:32:01 UTC 2014


#28113: class-wp-embed. height always fake in $attr
--------------------------+-------------------------
 Reporter:  alexufo       |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Embeds        |     Version:  3.9
 Severity:  normal        |  Resolution:  worksforme
 Keywords:                |     Focuses:
--------------------------+-------------------------
Changes (by wonderboymusic):

 * status:  reopened => closed
 * resolution:   => worksforme
 * milestone:  Awaiting Review =>


Comment:

 Not all embeds are rendered in landscape orientation. Default is
 calculated like so:
 `$height = min( ceil( $width * 1.5 ), 1000 );`

 Default value for `$width` is 500, unless `$GLOBALS['content_width']` is
 set.

 This is working as expected. If you pass `height` to your `embed`
 shortcode, it will override this default value:
 `$attr = wp_parse_args( $attr, wp_embed_defaults( $url ) );`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28113#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list