[wp-trac] [WordPress Trac] #29612: Query for multiple comment statuses

[WordPress Trac]

#29612: Query for multiple comment statuses
-------------------------------------------------+-------------------------
 Reporter:  ebinnion                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Comments                             |  Review
 Severity:  normal                               |     Version:  4.0
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by karpstrucking):

 Replying to [comment:3 nacin]:
 > There is a lot of history in those few lines of code. See #21101. I
 don't think this is as simple as wrapping a foreach around it, as 'all'
 probably needs to be handled a bit differently, etc.
 >
 > Also, would need unit tests.

 That was an interesting read, thanks for that. I believe my patch retains
 the existing handling for a status of 'all': it's still `"(
 comment_approved = '0' OR comment_approved = '1' )"`

 Although, it occurs to me that if 'all' is included as one of the statuses
 in an array, it will be ignored. I'm not sure what the behaviour should be
 in that situation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29612#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform