[wp-trac] [WordPress Trac] #29580: When a child-theme is active, the parent-theme should not be deletable.
WordPress Trac
noreply at wordpress.org
Wed Sep 10 15:47:19 UTC 2014
#29580: When a child-theme is active, the parent-theme should not be deletable.
--------------------------------------------------+------------------
Reporter: ounziw | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.1
Component: Themes | Version: 4.0
Severity: normal | Resolution:
Keywords: needs-testing has-patch dev-feedback | Focuses:
--------------------------------------------------+------------------
Comment (by DrewAPicture):
Replying to [comment:5 karpstrucking]:
> @DrewAPicture thanks for the feedback. updated patch attached. in `wp-
admin/themes.php` I went ahead and updated spacing for the containing if
statement, not just my own additions. it's a bit of a slippery slope and I
wasn't sure if there's a protocol for that - I'm happy to go further if
desired.
Looks pretty good. Yeah, the protocol on spacing out lines is that it
should only happen on lines that you're already changing or adding. This
is to prevent undue churn in the codebase. So in
[attachment:29580_gowp1.diff] you'd revert the spacing changes on lines
15, 17, 22, 25, and 27 for wp-admin/themes.php.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29580#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list