[wp-trac] [WordPress Trac] #29613: Arbitrary Customizer control input type support can cause unexpected output in custom controls
WordPress Trac
noreply at wordpress.org
Wed Sep 10 06:46:27 UTC 2014
#29613: Arbitrary Customizer control input type support can cause unexpected output
in custom controls
------------------------------+-------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.0.1
Component: Customize | Version: 4.0
Severity: normal | Keywords: needs-patch
Focuses: |
------------------------------+-------------------------
I just realized that we might run into potentially significant issues with
the fact that the base `render_content()` function in
`WP_Customize_Control` now outputs stuff for any given type if a custom
control subclass doesn't override the `render_content()` function.
This is likely to be the case for some custom controls that do all of
their rendering in JS. But there may not be a great solution. My best idea
is to create a whitelist of valid html5 input types to allow.
If we want to fix this it would be a 4.0.1 thing, otherwise we can wontfix
I think.
The workaround is just to add:
`public function render_content() {}`
to the custom control class.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29613>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list