[wp-trac] [WordPress Trac] #28454: Incorrect behaviour when Appearance > Customize saves front page options
WordPress Trac
noreply at wordpress.org
Sun Sep 7 21:19:27 UTC 2014
#28454: Incorrect behaviour when Appearance > Customize saves front page options
--------------------------+---------------------------------
Reporter: ElectricFeet | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: 3.9
Severity: normal | Resolution:
Keywords: | Focuses: ui, administration
--------------------------+---------------------------------
Comment (by ElectricFeet):
Replying to [comment:4 kwight]:
> `page_for_posts` probably shouldn't be reset when switching the ''Front
page displays'' setting, so that their last setting is maintained if the
user again switches back to a static page on front. I'd say we have the
correct behaviour already.
>
> Devs should just check against the `show_on_front` setting when trying
to determine if the front page is a static page or posts.
Thanks for picking this one up!
Personally, my vote would be to reset in both places (as Settings does
now), simply because users will change this rarely, but plugins and themes
will use it frequently. For users, it's a minor inconvenience not to
retain the setting; while for devs, it's a major pain to discover/debug
(it took me ages (as a user) to figure out what was wrong with the
Polylang plugin).
But I can live with whatever is considered to be the "correct" behaviour.
However, the problem is that the Customizer does one thing, while Settings
does another: for both `page_on_front` and `page_for_posts`, they behave
differently. It is this inconsistency that needs to be fixed---they should
behave in the same way.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28454#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list