[wp-trac] [WordPress Trac] #28949: endless loop in wordpress updates translations

[WordPress Trac]

#28949: endless loop in wordpress updates translations
-----------------------------+----------------------------
 Reporter:  Kniebremser      |       Owner:
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  WordPress.org
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:  fixed
 Keywords:                   |     Focuses:
-----------------------------+----------------------------
Changes (by nacin):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Hey all. I'm very sorry about this. I was wrong this whole time. It was
 absolutely a bug in the API.

 The installed languages that get sent to the API for parsing get passed
 off to the
 [https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/translations/lib.php
 translations library], specifically
 check_for_translations_of_installed_items(). That function is fine, it's
 what gets passed in that wasn't. It needed to pass in specifically that
 textdomain's languages, not everything that gets sent. For core, it was
 passing everything, so looking for a key of 'ru_RU' made no sense because
 it was at `['default']['ru_RU']`.

 Passing through the 'default' data wasn't enough, though. The language
 pack is identified by the PO-Creation-Date, which for a core language pack
 is the latest date of all containing PO files (default, admin, admin-
 network, and cc). So it had to figure out which one has the latest date
 based on the data passed back and then make sure that's the date that gets
 passed through for comparison.

 This is now all fixed and has been deployed for the last 50 minutes or so.
 Sorry again for the trouble.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28949#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform