[wp-trac] [WordPress Trac] #22271: get_post_class() does not always apply filter to output
WordPress Trac
noreply at wordpress.org
Wed Sep 3 20:20:21 UTC 2014
#22271: get_post_class() does not always apply filter to output
-------------------------------------+------------------------------
Reporter: F J Kaiser | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Posts, Post Types | Version: 3.4
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses: template
-------------------------------------+------------------------------
Changes (by obenland):
* keywords: has-patch dev-feedback => has-patch needs-refresh
Comment:
I think back compat trumps the expectation that a filter will be applied
to all return values. As nacin pointed out, WordPress is pretty consistent
about that inconsistency, and in the context of `get_post_class()` I'd
consider the lack of post context at least "unexpected", if not an
"error".
I like [attachment:22271_2a.patch]. Passing back the custom classes makes
sense to me. F J Kaiser, could you give the patch another do over with
[http://make.wordpress.org/core/handbook/coding-standards/php/ coding
standards] in mind?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/22271#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list