[wp-trac] [WordPress Trac] #29425: Plugin update: Translation update fails with "Invalid Data provided"

[WordPress Trac]

#29425: Plugin update: Translation update fails with "Invalid Data provided"
-----------------------------+------------------
 Reporter:  pavelevap        |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  4.0
Component:  I18N             |     Version:  3.7
 Severity:  blocker          |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------

Comment (by dd32):

 > upgrader_pre_install handled by 29425.patch​
 All testing shows that this is indeed a problem, and the patch indeed does
 fix it. I can't find anything wrong with it.

 > upgrader_clear_destination used to delete old plugins prior to plugin
 install.
 This one isn't triggered as 'clear_destination' is set to false in the
 Translation update call.

 > upgrader_post_install used for parent theme installs. No idea if this
 will cause issues, but might as well clear it too?
 The `Theme_Upgrader::check_parent_theme_filter` method gets called for the
 Translation update, but it passes in the event the parent theme has been
 installed, Ideally this shouldn't be run, as although it degrades
 gracefully for me, I can't say it'll always be so.

 When you take the above into account with someone using a customer
 upgrader in a premium theme or similar, we can't trust anything hooked to
 these filters, so we should just blow them all away IMHO.
 [attachment:29425.diff 29425.diff] does just that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29425#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform