[wp-trac] [WordPress Trac] #11330: Empty search takes you to homepage instead of empty search page

[WordPress Trac]

#11330: Empty search takes you to homepage instead of empty search page
--------------------------+-----------------------------
 Reporter:  jacobfogg     |       Owner:  wonderboymusic
     Type:  defect (bug)  |      Status:  reopened
 Priority:  low           |   Milestone:  4.0
Component:  Query         |     Version:  2.8.5
 Severity:  minor         |  Resolution:
 Keywords:                |     Focuses:
--------------------------+-----------------------------

Comment (by wonderboymusic):

 I actually checked out IS today on one of my sites. It was broken for a
 while, now it works. IS should be built by passing `query` not
 `query_vars`.

 They patched for 4.0:
 https://github.com/Automattic/jetpack/commit/baa5b7a8ffab784dbbb9f7e136dcbf387a6ffe38

 Since they are passing to `WP_Query` directly, those args are actually
 getting double parsed:
 https://github.com/Automattic/jetpack/blob/master/modules/infinite-
 scroll/infinity.php#L900

 Nobody makes a `WP_Query` with every arg passed. If you only pass the args
 that were originally passed (represented by `WP_Query->query`, you'll end
 up with all of those args anyways.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/11330#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform