[wp-trac] [WordPress Trac] #28090: Multiple add media buttons all have same ID attribute

WordPress Trac noreply at wordpress.org
Mon Sep 1 23:50:35 UTC 2014


#28090: Multiple add media buttons all have same ID attribute
----------------------------+-----------------------------
 Reporter:  helgatheviking  |       Owner:  wonderboymusic
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  Media           |     Version:  3.5
 Severity:  minor           |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I suspect someone may be relying on the first button being insert-media-
 button. I have two alternative solutions:

  * Is there a reason why IDs are needed at all here for all subsequent
 instances?

  * Or, can we make it so the first one is insert-media-button, and all
 later ones receive an ID appended?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28090#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list