[wp-trac] [WordPress Trac] #30164: Twenty Fifteen: merge Header & Sidebar text color controls

[WordPress Trac]

#30164: Twenty Fifteen: merge Header & Sidebar text color controls
------------------------------+------------------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  ui
------------------------------+------------------------------

Comment (by iamtakashi):

 Replying to [comment:2 celloexpressions]:
 > Appearance -> Header is being deprecated - it'll only be accessible by
 users with no js, on IE7 or in IE8 or IE9 on multisite with domain mapping
 (those are the situations when the Customizer isn't available). Users will
 otherwise be redirected to the appropriate controls in the Customizer So I
 actually think we shouldn't consider it at all in Twenty Fifteen, although
 I added it to that file for now.

 OK, that's good to know. In that case, I think hiding it with CSS is fine
 too.

 >
 > New patch addresses the other notes. Noting that we need to use the
 custom `sidebar_textcolor` control for this, since the core control is
 tied to the option to hide the header text, and this color applies to more
 than that.

 Yes. That makes sense.

 I've tested 30164.2.diff and I haven't seen anything weird other than the
 known issues — the escaped label #29572 and the default background color
 #30125, #30031.

 When this is committed, we can close #29980.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30164#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform