[wp-trac] [WordPress Trac] #30108: Twenty Fifteen: Underline menu links & post links in the archive on hover so it is clear they are links

WordPress Trac noreply at wordpress.org
Wed Oct 29 19:57:18 UTC 2014


#30108: Twenty Fifteen: Underline menu links & post links in the archive on hover
so it is clear they are links
-------------------------------------+--------------------------------
 Reporter:  KatherineMancuso         |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.1
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility
-------------------------------------+--------------------------------

Comment (by morganestes):

 Replying to [comment:12 iamtakashi]:
 > I had a look 30108.3.diff but there are still few issues.
 >
 > 1. The border rule needs to stay there in customizer.php for border
 color for `blockquote`. There are already secondary text color rules for
 those selectors just above.
 >
 > 2. If you specify `border:none;` in L: 1763, do we need `border-bottom:
 none;` in the big chunk of changes in style.css?
 >
 > 3. Then we can remove the`.entry-content a:focus` and `.entry-content
 a:hover` from the chunk.

 1. I pulled out just the `:hover` and `:focus` rules in the customizer,
 since they're not relevant any more, so it's just down to `blockquote` in
 that ruleset.
 2. Right, that's just duplicated needlessly. I tried to keep that ruleset
 instead of duplicating selectors, but it doesn't make much sense to have
 `border: none` in that line. I removed it from that selector and re-
 grouped all the a11y changes to the selectors in section 7.0.
 3. I vote for leaving the color changes in L:1769 (in new patch) since
 those are strictly style changes, and moving the border styles into the
 a11y section 7.0 in the stylesheet.

 I'm adding a new patch, `30108.4.diff` with these changes. It also fixes a
 selector error I missed before, and change the selector order to
 alphabetical so it's easier for me to read.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30108#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list