[wp-trac] [WordPress Trac] #30056: Twenty Fifteen: Menu hiccups

[WordPress Trac]

#30056: Twenty Fifteen: Menu hiccups
------------------------------+-----------------------------
 Reporter:  nhuja             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.1
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, javascript
------------------------------+-----------------------------

Comment (by afercia):

 Worth noting that in 2011 Paul Irish, by suggestion of Dan Beam, changed
 that regular expression that used word boundaries with a new one to avoid
 some (rare) edge cases, namely `\b also matches - or +`.

 For example, it fails if there's already a class like, say, `myplugin-no-
 js` as first class.

 The change is here:
 https://github.com/Modernizr/Modernizr/pull/358/files
 {{{
 (/(^|\s)no-js(\s|$)/, '$1$2')
 }}}

 For reference, it was changed again here:
 https://github.com/Modernizr/Modernizr/commit/71894c33b00082a52a9474a07751b3290576abf7
 to add the ability to prefix that class, not useful in our case.
 Current version source:
 https://github.com/Modernizr/Modernizr/blob/master/src/setClasses.js

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30056#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform