[wp-trac] [WordPress Trac] #30093: Codestyling and optimization

[WordPress Trac]

#30093: Codestyling and optimization
-------------------------+-----------------------------
 Reporter:  ipm-frommen  |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  4.1
Component:  Menus        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  administration
-------------------------+-----------------------------

Comment (by ipm-frommen):

 When I reviewed (and rethought) the sorting block within `do_meta_boxes` I
 realized that using the `$already_sorted` variable, in fact, is a good
 idea, because the function is being called several times - and sorting the
 metaboxes needs to be done just once.

 So here is yet another diff,
 [[https://core.trac.wordpress.org/attachment/ticket/30093/30093-4.diff|30093-4.diff]],
 containing just what this ticket is about: refactoring/improving the do-
 while(0) loop.

 I'd be happy if someone could delete the two attachments 30093-2.diff and
 30093-3.diff - just because they're faulty and irrelevant. Sorry for that.
 :(

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30093#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform