[wp-trac] [WordPress Trac] #28517: Logic error in WP_Rewrite flush_rules

[WordPress Trac]

#28517: Logic error in WP_Rewrite flush_rules
---------------------------+------------------------------
 Reporter:  numis          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Rewrite Rules  |     Version:  3.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by aaroncampbell):

 * keywords:  has-patch needs-testing needs-unit-tests => has-patch


Comment:

 Replying to [comment:8 markjaquith]:
 > Eh. True/false doesn't necessarily need to indicate success and failure.

 I talked to Mark about this. You're passing in a boolean, and basically
 returning that boolean after it's been filtered, which actually does makes
 sense. Also, the tests would be too heavy/complex if we didn't have a
 return to look at. As long as we document the return well I'm good with
 it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28517#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform