[wp-trac] [WordPress Trac] #29980: Twenty Fifteen: hidden header text control doesn't update with color scheme

[WordPress Trac]

#29980: Twenty Fifteen: hidden header text control doesn't update with color scheme
---------------------------+--------------------
 Reporter:  cainm          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.1
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+--------------------

Comment (by downstairsdev):

 @cainm You got closer to figuring it out than I did.

 I did see an issue with this patch:

 1. Start with default color scheme and title visible
 2. Hide title text
 3. Switch color scheme
 4. Show title
 5. Attempt to hide title text again (it fails to hide)

 I made a small fix to resolve that issue in 29980.3.diff.

 I agree this doesn't feel particularly elegant. I tried and approach using
 data attributes rather than passing "changedWhileHidden" around, but that
 seemed even worse.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29980#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform