[wp-trac] [WordPress Trac] #29980: Twenty Fifteen: hidden header text control doesn't update with color scheme

WordPress Trac noreply at wordpress.org
Thu Oct 23 18:23:33 UTC 2014


#29980: Twenty Fifteen: hidden header text control doesn't update with color scheme
---------------------------+--------------------
 Reporter:  cainm          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.1
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+--------------------

Comment (by downstairsdev):

 @cainm Tested your patch in Safari and appears to resolve the issue.

 I'm wondering if we should get rid of the "if ( 'blank' !== wp.customize(
 'header_textcolor' ).get() ) {" conditional altogether though.

 If you've selected "white" as the title color at some point, hid the
 title, switched the palette back to default at a later point and then
 showed the title, wouldn't you want it to match the color scheme? All the
 other colors update to match the scheme when it changes regardless of
 whether a custom color was set- I'm not sure this one should be different
 just because it was hidden at the time of the switch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29980#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list