[wp-trac] [WordPress Trac] #30064: WP_User_Query should support orderby => include

[WordPress Trac]

#30064: WP_User_Query should support orderby => include
-------------------------------------------------+-------------------------
 Reporter:  danielbachhuber                      |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Users                                |  Release
 Severity:  normal                               |     Version:
 Keywords:  good-first-bug needs-unit-tests      |  Resolution:
  needs-patch                                    |     Focuses:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * keywords:  good-first-bug has-patch needs-unit-tests => good-first-bug
     needs-unit-tests needs-patch


Comment:

 jipmoors - Thanks for the updated patch. You're right that these values
 need sanitization. Because they're IDs, our preferred technique for
 sanization would be `$include = implode( ',', array_map( 'intval',
 $qv['include'] ) );`. There should probably also be some sanity checks
 here to make sure that the value passed was an array (plus support for
 comma-separated strings, if this is a parameter that can be accessed via
 URL - I don't know off the top of my head, so this would need to be
 checked).

 Re formatting:
 https://core.trac.wordpress.org/attachment/ticket/30064/30064_gowp1-2.diff
 Looks like your editor may be formatted for spaces rather than tabs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30064#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform