[wp-trac] [WordPress Trac] #29887: Embedded video's .wp-video block is not responsive yet

[WordPress Trac]

#29887: Embedded video's .wp-video block is not responsive yet
-------------------------+------------------------------
 Reporter:  Surbma       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Embeds       |     Version:  4.0
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------

Comment (by jasonlcrane):

 This change to mediaelement.js
 (https://github.com/johndyer/mediaelement/commit/3db79d078ca21dade4319d87247e34c23847f1cf)
 requires the .wp-video element to have a height, which @wonderboymusic
 updated with this change:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/media.php?rev=29457

 My fix has been to change the height back to auto with javascript in the
 mediaelement success callback
 (https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/js/mediaelement/wp-mediaelement.js). I'm registering  my own
 version of that file already for other reasons.

 I will attach a patch with my fix to at least get the conversation
 started. I don't know that this is necessarily a good long term fix, but
 it's where I ended up for now. This is my first time submitting a patch,
 please let me know if I'm missing anything in that process. I've tested it
 on 4.0 with multiple themes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29887#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform