[wp-trac] [WordPress Trac] #30065: Twenty Fifteen: Heading Structure

[WordPress Trac]

#30065: Twenty Fifteen: Heading Structure
-------------------------------------+------------------------------
 Reporter:  bramd                    |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility
-------------------------------------+------------------------------
Changes (by rianrietveld):

 * keywords:   => has-patch needs-testing


Comment:

 Hi David,

 Tested the patch. Looks good :-)
 In content.php there is a check
 {{{
 if ( is_single() )
 }}}
 , maybe it's better to do
 {{{
 if ( is_singular() )
 }}}
 , then it works also with attachments and page post types.
 http://codex.wordpress.org/Function_Reference/is_single

 Added a patch for that, 30065.1.patch

 Furthermore, and this may be a bridge to far to change for this theme:
 There still is always a double H1. One for the site title, and one actual
 H1 that represents the content.

 To my opinion, the best solution would be:
 Don't put headings on the site title and the site description.
 And put the (real) H1 directly above the content, in this theme:
 In <header> of <main>.
 If home is "Your latest posts", hide the title by adding a screen-reader-
 text class, because in this case home is in fact an archive without a
 visual title.

 This way every webpage has a unique and meaningful H1 and the title is
 always on the same place in the HTML, super easy for screen reader users
 and (to my opinion) also better for SEO.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30065#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform