[wp-trac] [WordPress Trac] #15250: Filtering get_tax_sql for advanced queries

WordPress Trac noreply at wordpress.org
Sun Oct 19 23:17:04 UTC 2014


#15250: Filtering get_tax_sql for advanced queries
-------------------------+----------------------
 Reporter:  sc0ttkclark  |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Query        |     Version:  3.1
 Severity:  normal       |  Resolution:  wontfix
 Keywords:  has-patch    |     Focuses:
-------------------------+----------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => wontfix
 * milestone:  Future Release =>


Comment:

 I'm strongly against adding filters directly to SQL queries. It's terrible
 for future backward compatibility, and it's an invitation for plugins to
 do things that end up causing conflicts with other plugins. (If we could
 remove the filters in Date and Meta queries without breaking existing
 plugins, I would.) The changes to WP_Tax_Query in WP 4.1 make it so that
 pretty much any kind of tax query can be expressed in the syntax of the
 class, reducing the need for this filter; and anyone who *really* needs to
 filter SQL for some reason can still use filters like 'posts_where' in
 `WP_Query`.

 In the absence of a compelling use case, I'm going to say wontfix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15250#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list