[wp-trac] [WordPress Trac] #28504: Icons for Customizer Sections

WordPress Trac noreply at wordpress.org
Thu Oct 16 04:56:36 UTC 2014


#28504: Icons for Customizer Sections
------------------------------+------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.1
Component:  Customize         |     Version:  3.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  ui
------------------------------+------------------

Comment (by celloexpressions):

 Replying to [comment:20 obenland]:
 > Looking at the latest patches, what do you think of adding the
 `dashicon-` prefix on output in `class-wp-customize-panel.php` and `class-
 wp-customize-section.php`? Shouldn't they be escaped too?
 By not assuming a `dashicon` prefix, we would allow other class-based font
 icons, or targeted background-image icons to be used ([comment:16])
 without worrying about potential conflicts with future dashicons. Also
 makes it clearer that it's a dashicon they're using when they add the
 icon.

 We should probably add `esc_attr()` around the icon output, though.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28504#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list