[wp-trac] [WordPress Trac] #21760: get_term_by() calls are not cached

[WordPress Trac]

#21760: get_term_by() calls are not cached
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:  4.1
Component:  Taxonomy        |     Version:  2.3
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------

Comment (by nacin):

 This looks great, but I'm reopening for some potential tweaks:
  * wp_get_last_changed() is really weird. I am not against helpers but in
 this case it seems to do too many things and is generally confusing to
 see. It gets the value but sometimes sets the value? The name is wrong. As
 it stands I'd eliminate it.
  * This suddenly adds new and arbitrary groups. That's not really good. We
 should have individual buckets for slugs and names (as done in users),
 potentially with generic names (like 'termslugs' and 'termnames' ).
  * Why the md5? Key length? Whitespace?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21760#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform