[wp-trac] [WordPress Trac] #29977: Hook doc for xmlrpc_element_limit filter

[WordPress Trac]

#29977: Hook doc for xmlrpc_element_limit filter
--------------------------+---------------------------
 Reporter:  ankit.gade@…  |       Owner:  DrewAPicture
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.1
Component:  XML-RPC       |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  docs
--------------------------+---------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * owner:   => DrewAPicture
 * status:  new => reviewing
 * milestone:  Awaiting Review => 4.1


Comment:

 Hi ankit, thanks for the patch. Couple things:

 * The docblock should align with hook line itself, currently it's indented
 quite a bit
 * "The limit of elements" is a little ambiguous, maybe change that to
 something like "Filter the number of elements to parse in an XML-RPC
 response"
 * The `@since` tag should use the 3-digit, x.x.x style for the version
 * There should be a period at the end of the `@param` description

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29977#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform