[wp-trac] [WordPress Trac] #12668: Better support for custom comment types
WordPress Trac
noreply at wordpress.org
Wed Oct 15 03:15:15 UTC 2014
#12668: Better support for custom comment types
----------------------------------------+------------------------------
Reporter: ptahdunbar | Owner: ptahdunbar
Type: enhancement | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests | Focuses:
----------------------------------------+------------------------------
Comment (by joshlevinson):
Replying to [comment:61 mordauk]:
> [https://core.trac.wordpress.org/attachment/ticket/12668/12668-comments-
query.patch 12668-comments-query.patch] addresses that issue.
I may be wrong, but I don't think that patch (or any so far on this
ticket) addresses what boonebgorges is discussing. I think boonebgorges is
questioning the first item of the scope you defined. That is, whether it's
best to remove all but the default comment types from
display/administration or to keep them in comment queries and allow—via
filters—the opposite: explicit ''removal'' of specific types from the
queries.
Replying to [comment:58 boonebgorges]:
> ...there are probably many cases where the existing behavior is being
relied upon by users and by plugins. Changing the defaults for these UIs
so that only core comments appear has the potential to confuse. ... Do
others have thoughts about this?
IMO, users and plugins that do rely on built-in administration/display for
custom comment types are relying on an unsupported ability that isn't
documented or promoted anywhere. Defining the correct behavior here is new
territory, so it may be best to just make a clean break and require
anything built on current behavior to conform.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/12668#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list