[wp-trac] [WordPress Trac] #12668: Better support for custom comment types

[WordPress Trac]

#12668: Better support for custom comment types
-------------------------+------------------------------
 Reporter:  ptahdunbar   |       Owner:  ptahdunbar
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by dancameron):

 12668-comments-query.2.patch doesn't do much more than change the
 formatting of the code that @mordauk submitted, in order to conform to
 whatever standards are applied to the rest of that query method.

 I really want to change the get_approved_comments function, I don't know
 how to describe my angst towards it. Firstly, it's not even being used by
 anything in core than comments-popup (which brings back memories);
 Secondly, I feel that it should be using WP_Comment_Query...I'll create a
 totally separate patch.

 Replying to [comment:52 mordauk]:

 > I also went ahead and separated each modified file into separate
 patches. Not sure if that makes it easier or more difficult to review :)

 In order to keep track it's gonna be a real hassle if the diff/patch files
 get changed. So let's try to keep them as is (although I wouldn't be
 apposed to naming the files based off the file names).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12668#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform