[wp-trac] [WordPress Trac] #29925: Setting WP_DEFAULT_THEME to a custom theme causes test to fail

[WordPress Trac]

#29925: Setting WP_DEFAULT_THEME to a custom theme causes test to fail
------------------------------+------------------------------
 Reporter:  mboynes           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by nacin):

 So, it ''is'' there for a reason, believe it or not. I think I wrote this
 one.

 When we add a new theme, we update WP_DEFAULT_THEME. This isn't something
 we'll forget. But it's very possible that we'll forget to update the
 $default_themes property of the Tests_Theme class. That's why this
 assertion is there.

 I'm generally not against adjusting poor assumptions in our unit tests,
 but we also can't make a guarantee that they'll always pass when the
 default environment is changed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29925#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform