[wp-trac] [WordPress Trac] #25834: WP_Date_Query not allowed values possible

[WordPress Trac]

#25834: WP_Date_Query not allowed values possible
----------------------------------+---------------------------
 Reporter:  ChriCo                |       Owner:  boonebgorges
     Type:  defect (bug)          |      Status:  accepted
 Priority:  normal                |   Milestone:  4.1
Component:  Query                 |     Version:  3.7
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-docs  |     Focuses:
----------------------------------+---------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => has-patch needs-docs


Comment:

 Couple of docs notes on [attachment:25834.patch]:

 * We'll need translator comments for the specifiers in the `$min_max_msg`
 string
 * A comment or two in or around the `foreach ( $min_max_checks as $key =>
 $check ) {` block would be helpful
 * The return description on `validate_date_values()` is incomplete
 * Probably also worth mentioning in the long description for
 `WP_Date_Query::__construct()` that values will be sanitized and what will
 happen if invalid values are passed. Doesn't necessarily need to be super
 granular but we do need to specify the expected result either way

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25834#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform