[wp-trac] [WordPress Trac] #17680: Using "update automatically" can destroy a theme in a Windows environment

[WordPress Trac]

#17680: Using "update automatically" can destroy a theme in a Windows environment
------------------------------------+-----------------------------
 Reporter:  blurback                |       Owner:  dd32
     Type:  defect (bug)            |      Status:  reviewing
 Priority:  normal                  |   Milestone:  Future Release
Component:  Upgrade/Install         |     Version:
 Severity:  major                   |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------------

Comment (by dd32):

 > A fix could also be not to require a folder to be deleted, to proceed
 with an update, as long as it's empty. I'm not sure why and update must
 fail if the folder itself is not deleted, but I guess there is a reason.

 That's a valid point, As long as the original and destination folders are
 the same, there's no need to remove the directory, which would indirectly
 work around some of the filesystem level locks (It won't prevent a failure
 when the lock prevents deleting a file, or the lock is on a subdirectory).

 While this sounds like a simple change, it's not exactly that simple when
 you look at the upgrade routines for that area of code, although it's a
 possibility.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17680#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform