[wp-trac] [WordPress Trac] #7092: Should support separate setting for limiting comments feed
WordPress Trac
noreply at wordpress.org
Thu Oct 9 13:04:56 UTC 2014
#7092: Should support separate setting for limiting comments feed
-------------------------+-----------------------
Reporter: redsweater | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone:
Component: Feeds | Version: 2.9
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------+-----------------------
Changes (by redsweater):
* status: closed => reopened
* resolution: duplicate =>
Comment:
Replying to [comment:26 chriscct7]:
> This was fixed in #9635 and further revised in #9886
I don't think either of the cited tickets are suitable duplicates of this
one. Trunk WordPress still doesn't support the feature requested by this
ticket: separate user control over the number of items in the comments
feed.
nacin's earlier patch made the point of establishing a new setting for
"comments_per_rss", and added UI to the reading options in the settings
admin UI. Neither of those goals is achieved (so far as i can tell) by the
tickets cited as duplicates.
Take a look at wp-includes/query.php line 3129 in today's trunk core
sources to see that comment_feed_limits is derived from posts_per_rss, and
there doesn't appear to be any user setting for overriding that.
It seems that because the patch was never approved, it will probably need
to be revised to apply cleanly on modern trunk. I can take a stab at this
unless the climate has changed since 5 years ago and it is no longer
thought this ticket stands a chance ;)
If it's going to be closed, it should be closed as invalid instead of
incorrectly stating that other tickets have rendered it moot.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/7092#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list