[wp-trac] [WordPress Trac] #29589: term_exists() short-circuits and results in duplicate inserts.

WordPress Trac noreply at wordpress.org
Thu Oct 9 03:15:52 UTC 2014


#29589: term_exists() short-circuits and results in duplicate inserts.
-----------------------------------+---------------------------
 Reporter:  georgestephanis        |       Owner:  boonebgorges
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  4.1
Component:  Taxonomy               |     Version:  trunk
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"29865"]:
 {{{
 #!CommitTicketReference repository="" revision="29865"
 Don't bail out of term_exists() when term sanitizes to an empty string.

 This change brings return values for failures of this sort in line with
 other
 failed lookups in term_exists(): a null value is now returned in all cases
 where the queried term is not found.

 Adds unit test for the sanitization issue. Modifies existing unit test to
 reflect the change in return value for empty term strings.

 Props boonebgorges, georgestephanis.
 Fixes #29589.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29589#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list