[wp-trac] [WordPress Trac] #29881: Better abstraction for WP_Posts_List_Table so it's easier to subclass
WordPress Trac
noreply at wordpress.org
Tue Oct 7 21:14:42 UTC 2014
#29881: Better abstraction for WP_Posts_List_Table so it's easier to subclass
----------------------------+-----------------------------
Reporter: joehoyle | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.1
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: | Focuses: administration
----------------------------+-----------------------------
Comment (by joehoyle):
> column_taxonomy() should probably be protected. Also, it should probably
have a name other than column_ because it could otherwise be invoked by
single_row_columns().
Agreed, I did originally have this as private, but then moved to public
for other to use it - though I think realistically it's only subclasses
that will use it so protected it good. As for naming, it's a workaround
for avoiding accidental calling via `single_row_columns` so though as much
as I hate underscored methods, `protected function _column_taxonomy` might
make the most sense here. `get_taxonomy_column` doesn't follow as it
outputs data, `output_taxonomy_column` -- perhaps.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29881#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list