[wp-trac] [WordPress Trac] #22301: Performance problem with Recent Comments widget

[WordPress Trac]

#22301: Performance problem with Recent Comments widget
--------------------------+--------------------------
 Reporter:  pento         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.1
Component:  Comments      |     Version:  2.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+--------------------------
Changes (by kovshenin):

 * keywords:  has-patch commit => has-patch


Comment:

 [attachment:22301.diff] won't work because regardless of whether the lock
 was acquired, the `widget()` method will output the data from the _old
 cache and return, leaving us with a lock that will never be released.

 Also, I think that this approach will not work when multiple instances of
 the same widget are used. We're storing all the cached data under the same
 key which holds an array with multiple widget IDs, so with the proposed
 patch it looks like we'll acquire a lock and update only the first
 instance of the widget.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22301#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform