[wp-trac] [WordPress Trac] #13310: Extend option_name to varchar(255)

[WordPress Trac]

#13310: Extend option_name to varchar(255)
---------------------------------------------+-----------------------------
 Reporter:  scribu                           |       Owner:
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  Future Release
Component:  Database                         |     Version:  3.4.2
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch 2nd-opinion 4.1-early  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by Hube2):

 @nerrad

 I completely agree.

 What exposed this problem for me?

 I use the plugin Advanced Custom Fields (ACF). For those not familiar with
 it, you can add custom fields to options pages. The values for options
 pages are stored in the options table. This is not a problem most of the
 time. The problem manifests itself when using nested repeater fields or
 flexible content fields because of the way that ACF generates the
 option_name values of these types of fields.

 I didn't get into using transients until after I discovered the issue with
 ACF, and being already aware of the that issue I already knew I needed to
 be careful when generating the option_name for any transients I was
 creating.

 But as you say, I would really like to understand why, what I think is an
 extremely simple fix, would cause any issues for any site, network or not.
 I have gone into many sites, both network sites and not, small sites and
 huge sites, and manually changed option_name from 64 to 255 and never had
 a problem. I've even created my own MU plugin that I install on these
 sites to prevent WP from changing it back again. So I'm really confused
 about what problems this could create and why it has been waiting 5 years
 with no action taken.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/13310#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform