[wp-trac] [WordPress Trac] #28864: Cannot access edit menu options with keyboard inside Image Editor

[WordPress Trac]

#28864: Cannot access edit menu options with keyboard inside Image Editor
-------------------------------------+--------------------------------
 Reporter:  davidakennedy            |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Media                    |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility
-------------------------------------+--------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch needs-testing
 * focuses:  accessibility => ui, accessibility


Comment:

 First try to improve image editor accessibility. Please notice in the
 media views there's not even a real form element (unless I'm missing
 something), so just tried to make the fields and controls a bit more
 semantic.
 In the proposed patch:
 - the main buttons are now buttons
 - added some fieldsets and legends to group related controls, screen
 readers are happy
 - added some missing labels
 - the help toggles are now keyboard accessible and use `aria-expanded`
 attribute

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28864#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform