[wp-trac] [WordPress Trac] #30355: Create get_author_posts_link() function to return rather than echo HTML-formatted author posts link
WordPress Trac
noreply at wordpress.org
Mon Nov 24 07:45:44 UTC 2014
#30355: Create get_author_posts_link() function to return rather than echo HTML-
formatted author posts link
-------------------------+-----------------------------
Reporter: chipbennett | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: template
-------------------------+-----------------------------
Changes (by obenland):
* focuses: => template
* milestone: Awaiting Review => Future Release
Comment:
I like it, sounds like a sound improvement.
A few things I noticed:
* We should probably call it `get_the_author_posts_link()`.
* The comment for `the_author_posts_link()` can start with "Display"
again, rather than "Get".
* `the_author_posts_link()` would need to continue accepting the
deprecated argument.
* We can drop the deprecated argument from `get_the_author_posts_link()`
and don't need to pass it to it in the display function.
* The double line break between the two functions should probably just
remain one.
* I'm not sure we need to update the function body with current coding
guidelines, since it doesn't really need alterations, except for returning
the result.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30355#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list