[wp-trac] [WordPress Trac] #28319: Add hook to WP_Error for logging and report purposes

[WordPress Trac]

#28319: Add hook to WP_Error for logging and report purposes
-----------------------------------+-----------------------------
 Reporter:  ebinnion               |       Owner:  johnbillion
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  Future Release
Component:  General                |     Version:  4.0
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+-----------------------------

Comment (by sboisvert):

 I strongly support this patch and we currently have a version of this
 running on WP.com.

 There are some instances in the code where it's impossible to catch
 WP_Errors and they will cause fatals (because a string is expected
 upstream) and WP_Errors are returned before filtering.

 In this specific case get_terms_to_edit() returns a WP_Error for a
 taxonomy that Schrödinger exists, it's then used as a string causing a
 fatal in the admin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28319#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform