[wp-trac] [WordPress Trac] #30428: Admin bar cannot be turn off for users with administrator's role

[WordPress Trac]

#30428: Admin bar cannot be turn off for users with administrator's role
-------------------------------------------+-----------------------------
 Reporter:  Cypves                         |      Owner:
     Type:  defect (bug)                   |     Status:  new
 Priority:  normal                         |  Milestone:  Awaiting Review
Component:  Administration                 |    Version:  4.0.1
 Severity:  normal                         |   Keywords:
  Focuses:  accessibility, administration  |
-------------------------------------------+-----------------------------
 There is a filter "show_admin_bar" which determinate whether the admin bar
 is shown or not. But for users with administrator's roles there isn't way
 how the admin bar disable because of a condition in front of line where
 the filter is applying.

 The following function is from admin-bar.php.

 {{{
 /**
  * Determine whether the admin bar should be showing.
  *
  * @since 3.1.0
  *
  * @return bool Whether the admin bar should be showing.
  */
 function is_admin_bar_showing() {
         global $show_admin_bar, $pagenow;

         // For all these types of requests, we never want an admin bar.
         if ( defined('XMLRPC_REQUEST') || defined('DOING_AJAX') ||
 defined('IFRAME_REQUEST') )
                 return false;

         // Integrated into the admin.
         if ( is_admin() )
 <---------------------------------------
         return true;

         if ( ! isset( $show_admin_bar ) ) {
                 if ( ! is_user_logged_in() || 'wp-login.php' == $pagenow )
 {
                         $show_admin_bar = false;
                 } else {
                         $show_admin_bar = _get_admin_bar_pref();
                 }
         }

         /**
          * Filter whether to show the admin bar.
          *
          * Returning false to this hook is the recommended way to hide the
 admin bar.
          * The user's display preference is used for logged in users.
          *
          * @since 3.1.0
          *
          * @param bool $show_admin_bar Whether the admin bar should be
 shown. Default false.
          */
         $show_admin_bar = apply_filters( 'show_admin_bar', $show_admin_bar
 );

         return $show_admin_bar;
 }
 }}}

 I recommend that condition give away.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30428>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform